Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2412613002: Support native app redirects to herb. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
Yusuf, Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support native app redirects to herb. If in Herb mode, use the same intent handling logic as Chrome, which more aggressively intents out to external applications than a normal CCT. BUG=653254 Committed: https://crrev.com/c7d93aa45e9eb180b86caa4c1be44f14a4339dd7 Cr-Commit-Position: refs/heads/master@{#424483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 3 chunks +14 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java View 3 chunks +12 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ted C
Working on tests, but fighting with ActivityMonitors. Will likely land those in a followup to ...
4 years, 2 months ago (2016-10-11 16:52:55 UTC) #2
Maria
lgtm
4 years, 2 months ago (2016-10-11 17:09:28 UTC) #3
Yusuf
lgtm
4 years, 2 months ago (2016-10-11 17:18:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412613002/1
4 years, 2 months ago (2016-10-11 17:19:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:59:45 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 18:03:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7d93aa45e9eb180b86caa4c1be44f14a4339dd7
Cr-Commit-Position: refs/heads/master@{#424483}

Powered by Google App Engine
This is Rietveld 408576698