Don't record Signin_Signin_From* user actions for re-auth, unlock and adding secondary account

Don't record Signin_Signin_From* user actions for re-auth, unlock and adding secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e24072b0a38056ab3eb09d032b24addcfc69ac23
Cr-Commit-Position: refs/heads/master@{#425036}

[gogerald1, 2016-10-11 18:56:51]

Description was changed from

==========
format


fix

BUG=
==========

to

==========
format


fix

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[gogerald1, 2016-10-11 18:58:20]

Description was changed from

==========
format


fix

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[gogerald1, 2016-10-11 18:59:38]

Description was changed from

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[gogerald1, 2016-10-11 18:59:51]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 19:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-11 19:01:34]

gogerald@chromium.org changed reviewers:
+ rogerta@chromium.org

[gogerald1, 2016-10-11 19:01:35]

Hi, PTAL,

[commit-bot: I haz the power, 2016-10-11 19:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:09:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Roger Tawa OOO till Jul 10th, 2016-10-12 15:16:45]

lgtm, one question below.

https://codereview.chromium.org/2411883002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler.cc (right):

https://codereview.chromium.org/2411883002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler.cc:203: reason !=
signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {
Instead of checking for not reauth|unlock|add-secondary, would it be better to
check explicitly for REASON_SIGNIN_PRIMARY_ACCOUNT?  I ask because currently if
the reason is REASON_UNKNOWN_REASON we will record metrics, and I'm not sure if
we want to or not.

[gogerald1, 2016-10-12 15:21:30]

gogerald@chromium.org changed reviewers:
+ bauerb@chromium.org

[gogerald1, 2016-10-12 15:21:31]

bauerb@chromium.org: Please review changes in 

*/inline_login.js

https://codereview.chromium.org/2411883002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler.cc (right):

https://codereview.chromium.org/2411883002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler.cc:203: reason !=
signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {
On 2016/10/12 15:16:45, Roger Tawa wrote:
> Instead of checking for not reauth|unlock|add-secondary, would it be better to
> check explicitly for REASON_SIGNIN_PRIMARY_ACCOUNT?  I ask because currently
if
> the reason is REASON_UNKNOWN_REASON we will record metrics, and I'm not sure
if
> we want to or not.

I think we might have to record it since if the reason is REASON_UNKNOWN_REASON
we will sign in the account as primary account, like here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_lo...

[gogerald1, 2016-10-12 15:22:04]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 15:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:30:57]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bernhard Bauer, 2016-10-13 12:57:02]

lgtm

[gogerald1, 2016-10-13 13:57:33]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-13 13:57:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:20:21]

Description was changed from

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-13 15:20:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 15:22:40]

Description was changed from

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't record Signin_Signin_From* user actions for re-auth, unlock and adding
secondary account

This CL also fixes the bug in CL https://codereview.chromium.org/2384233002/

BUG=632052
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e24072b0a38056ab3eb09d032b24addcfc69ac23
Cr-Commit-Position: refs/heads/master@{#425036}
==========

[commit-bot: I haz the power, 2016-10-13 15:22:41]

Patchset 1 (id:??) landed as
https://crrev.com/e24072b0a38056ab3eb09d032b24addcfc69ac23
Cr-Commit-Position: refs/heads/master@{#425036}