Don't record Signin_Signin_From* user actions for re-auth, unlock and adding secondary account

chrome/browser/ui/webui/signin/inline_login_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
 
 #include <limits.h>
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 180 matching lines @@
   GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
   params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
   params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
 
   const GURL& current_url = web_ui()->GetWebContents()->GetURL();
   signin_metrics::AccessPoint access_point =
       signin::GetAccessPointForPromoURL(current_url);
   signin_metrics::Reason reason =
       signin::GetSigninReasonForPromoURL(current_url);
 
-  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION ||
-      reason != signin_metrics::Reason::REASON_UNLOCK ||
+  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION &&
+      reason != signin_metrics::Reason::REASON_UNLOCK &&
       reason != signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {

[Roger Tawa OOO till Jul 10th, 2016/10/12 15:16:45]

Instead of checking for not reauth|unlock|add-secondary, would it be better to
check explicitly for REASON_SIGNIN_PRIMARY_ACCOUNT?  I ask because currently if
the reason is REASON_UNKNOWN_REASON we will record metrics, and I'm not sure if
we want to or not.

[gogerald1, 2016/10/12 15:21:30]

I think we might have to record it since if the reason is REASON_UNKNOWN_REASON
we will sign in the account as primary account, like here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_lo...

     signin_metrics::LogSigninAccessPointStarted(access_point);
+    RecordSigninUserActionForAccessPoint(access_point);
+    content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
+    params.SetBoolean("isLoginPrimaryAccount", true);
   }
-  RecordSigninUserActionForAccessPoint(access_point);
-  content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
 
   params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
 
   Profile* profile = Profile::FromWebUI(web_ui());
   std::string default_email;
   if (reason == signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT) {
     default_email =
         profile->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername);
   } else {
     if (!net::GetValueForKeyInQuery(current_url, "email", &default_email))
@@ skipping 61 matching lines @@
 
 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) {
   Browser* browser = signin::GetDesktopBrowser(web_ui());
   // If the dialog was opened in the User Manager browser will be null here.
   if (browser)
     browser->CloseModalSigninWindow();
 
   // Does nothing if user manager is not showing.
   UserManager::HideReauthDialog();
 }