Don't record Signin_Signin_From* user actions for re-auth, unlock and adding secondary account

chrome/browser/ui/webui/signin/inline_login_handler.cc

Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index 3f7b633eb371c34f8258d3edc9c1ee0058706b3a..e9a1901b1f62cc49d03d0a291a49da3c87621d27 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -198,13 +198,14 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() {
   signin_metrics::Reason reason =
       signin::GetSigninReasonForPromoURL(current_url);
 
-  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION ||
-      reason != signin_metrics::Reason::REASON_UNLOCK ||
+  if (reason != signin_metrics::Reason::REASON_REAUTHENTICATION &&
+      reason != signin_metrics::Reason::REASON_UNLOCK &&
       reason != signin_metrics::Reason::REASON_ADD_SECONDARY_ACCOUNT) {

[Roger Tawa OOO till Jul 10th, 2016/10/12 15:16:45]

Instead of checking for not reauth|unlock|add-secondary, would it be better to
check explicitly for REASON_SIGNIN_PRIMARY_ACCOUNT?  I ask because currently if
the reason is REASON_UNKNOWN_REASON we will record metrics, and I'm not sure if
we want to or not.

[gogerald1, 2016/10/12 15:21:30]

I think we might have to record it since if the reason is REASON_UNKNOWN_REASON
we will sign in the account as primary account, like here
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_lo...

     signin_metrics::LogSigninAccessPointStarted(access_point);
+    RecordSigninUserActionForAccessPoint(access_point);
+    content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
+    params.SetBoolean("isLoginPrimaryAccount", true);
   }
-  RecordSigninUserActionForAccessPoint(access_point);
-  content::RecordAction(base::UserMetricsAction("Signin_SigninPage_Loading"));
 
   params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());