Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
diff --git a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
index b7c9cc96eda167797e0f4a64b394f5805f8b1adb..9eb858dd89ccd68bc9659cb32b3e7df5d1c2320e 100644
--- a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
+++ b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
@@ -48,7 +48,7 @@ void V8PromiseResolver::fulfillMethodCustom(const v8::FunctionCallbackInfo<v8::V
v8::Isolate* isolate = args.GetIsolate();
V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
- v8::Local<v8::Value> result = v8::Undefined();
+ v8::Local<v8::Value> result = v8::Undefined(isolate);
if (args.Length() > 0)
result = args[0];
V8PromiseCustom::fulfillResolver(resolver, result, V8PromiseCustom::Asynchronous, isolate);
@@ -65,7 +65,7 @@ void V8PromiseResolver::resolveMethodCustom(const v8::FunctionCallbackInfo<v8::V
v8::Isolate* isolate = args.GetIsolate();
V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
- v8::Local<v8::Value> result = v8::Undefined();
+ v8::Local<v8::Value> result = v8::Undefined(isolate);
if (args.Length() > 0)
result = args[0];
V8PromiseCustom::resolveResolver(resolver, result, V8PromiseCustom::Asynchronous, isolate);
@@ -82,7 +82,7 @@ void V8PromiseResolver::rejectMethodCustom(const v8::FunctionCallbackInfo<v8::Va
v8::Isolate* isolate = args.GetIsolate();
V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
- v8::Local<v8::Value> result = v8::Undefined();
+ v8::Local<v8::Value> result = v8::Undefined(isolate);
if (args.Length() > 0)
result = args[0];
V8PromiseCustom::rejectResolver(resolver, result, V8PromiseCustom::Asynchronous, isolate);
« no previous file with comments | « Source/bindings/v8/custom/V8IDBAnyCustom.cpp ('k') | Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698