Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2411303002: Prune deprecated functions from VisibleSelection and VisibleUnits (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from VisibleSelection and VisibleUnits This patch prunes all deprecated functions from VisibleSelection and VisibleUnits because they have no callers any more. The following functions are removed: - VisibleSelection::visible{Start,End}Deprecated - createVisibleSelectionDeprecated (all overloads) - paragraph-related deprecated functions (in VisibleUnits) - {previous,next}PositionOf (in VisibleUnits) BUG=647219, 648949, 651373 Committed: https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665 Cr-Commit-Position: refs/heads/master@{#424732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -412 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 2 chunks +0 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -137 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 2 chunks +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 8 chunks +0 lines, -162 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL. Last patch for today...
4 years, 2 months ago (2016-10-12 08:30:06 UTC) #5
yosin_UTC9
lgtm You did it! (^_^)人(^_^)
4 years, 2 months ago (2016-10-12 09:20:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411303002/1
4 years, 2 months ago (2016-10-12 13:58:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 14:03:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 14:05:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665
Cr-Commit-Position: refs/heads/master@{#424732}

Powered by Google App Engine
This is Rietveld 408576698