Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2411303002: Prune deprecated functions from VisibleSelection and VisibleUnits (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 282f0666f72d8e1803d0e3a41f87abbb3e8b3ab5..c558d248950382e380155fbb901701d766ad71e7 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -105,18 +105,6 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
: affinity());
}
- // These deprecated functions perform synchronous layout, messing up the
- // pipeline. Callers should ensure clean layout and then switch to the
- // un-deprecated functions above.
- VisiblePositionTemplate<Strategy> visibleStartDeprecated() const {
- return createVisiblePositionDeprecated(
- m_start, isRange() ? TextAffinity::Downstream : affinity());
- }
- VisiblePositionTemplate<Strategy> visibleEndDeprecated() const {
- return createVisiblePositionDeprecated(
- m_end, isRange() ? TextAffinity::Upstream : affinity());
- }
-
bool operator==(const VisibleSelectionTemplate&) const;
bool operator!=(const VisibleSelectionTemplate& other) const {
return !operator==(other);
@@ -273,56 +261,6 @@ CORE_EXPORT VisibleSelectionInFlatTree
createVisibleSelection(const PositionInFlatTreeWithAffinity&,
bool isDirectional = false);
-// Callers of these functions should ensure clean layout by themselves and then
-// switch to the proper versions (to be introduced).
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const Position&,
- TextAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const Position& base,
- const Position& extent,
- TextAffinity = SelDefaultAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const EphemeralRange&,
- TextAffinity = SelDefaultAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const VisiblePosition&,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const VisiblePosition&,
- const VisiblePosition&,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelection
-createVisibleSelectionDeprecated(const PositionWithAffinity&,
- bool isDirectional = false);
-
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const PositionInFlatTree&,
- TextAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const PositionInFlatTree& base,
- const PositionInFlatTree& extent,
- TextAffinity = SelDefaultAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const EphemeralRangeInFlatTree&,
- TextAffinity = SelDefaultAffinity,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const VisiblePositionInFlatTree&,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const VisiblePositionInFlatTree&,
- const VisiblePositionInFlatTree&,
- bool isDirectional = false);
-CORE_EXPORT VisibleSelectionInFlatTree
-createVisibleSelectionDeprecated(const PositionInFlatTreeWithAffinity&,
- bool isDirectional = false);
-
// We don't yet support multi-range selections, so we only ever have one range
// to return.
CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698