Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2412043002: Prune createVisibleSelectionDeprecated from EditCommand::setEndingSelection (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from EditCommand::setEndingSelection This patch prunes createVisibleSelectionDeprecated from the above function as all callers have ensured clean layout and valid VisiblePosition as input. BUG=651373 Committed: https://crrev.com/c50cabb44a4c3f050f0d1bb260960b62e1f266ea Cr-Commit-Position: refs/heads/master@{#424730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-12 07:58:34 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-12 08:06:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412043002/1
4 years, 2 months ago (2016-10-12 13:36:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 13:41:34 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:43:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c50cabb44a4c3f050f0d1bb260960b62e1f266ea
Cr-Commit-Position: refs/heads/master@{#424730}

Powered by Google App Engine
This is Rietveld 408576698