Issue 2410823002: [modules] Simplify installation of @@toStringTag on namespace objects.

Issue 2410823002: [modules] Simplify installation of @@toStringTag on namespace objects. (Closed)

Created:
4 years, 2 months ago by neis

Modified:
4 years, 2 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[modules] Simplify installation of @@toStringTag on namespace objects. Install it as DataConstantDescriptor, not AccessorConstantDescriptor. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/8d18f42faec1723d2f4e188a27d869b7b382c812 Cr-Commit-Position: refs/heads/master@{#40180}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -23 lines)			Patch
M	src/accessors.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/accessors.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410823002/1

4 years, 2 months ago (2016-10-11 15:55:33 UTC) #4

commit-bot: I haz the power

4 years, 2 months ago (2016-10-11 16:26:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8d18f42faec1723d2f4e188a27d869b7b382c812
Cr-Commit-Position: refs/heads/master@{#40180}