Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/accessors.cc

Issue 2410823002: [modules] Simplify installation of @@toStringTag on namespace objects. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index abf4680ddec6ac025947f1fd7e7903ccef07752e..b88ebc3d7910cdd41038e5725f53bd04f67f087c 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -203,24 +203,6 @@ Handle<AccessorInfo> Accessors::ArrayLengthInfo(
}
//
-// Accessors::ModuleNamespaceToStringTag
-//
-
-void Accessors::ModuleNamespaceToStringTagGetter(
- v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) {
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate());
- info.GetReturnValue().Set(
- Utils::ToLocal(isolate->factory()->NewStringFromAsciiChecked("Module")));
-}
-
-Handle<AccessorInfo> Accessors::ModuleNamespaceToStringTagInfo(
- Isolate* isolate, PropertyAttributes attributes) {
- Handle<Name> name = isolate->factory()->to_string_tag_symbol();
- return MakeAccessor(isolate, name, &ModuleNamespaceToStringTagGetter, nullptr,
- attributes);
-}
-
-//
// Accessors::ModuleNamespaceEntry
//
« no previous file with comments | « src/accessors.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698