Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/bootstrapper.cc

Issue 2410823002: [modules] Simplify installation of @@toStringTag on namespace objects. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 74f2b2926c08f93e87c22044913e1156517f110b..6cc9d77c541cfb3a242c7e16c42af3d9223f69e9 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2140,10 +2140,9 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
// Install @@toStringTag.
PropertyAttributes attribs =
static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY);
- Handle<AccessorInfo> toStringTag =
- Accessors::ModuleNamespaceToStringTagInfo(isolate, attribs);
- AccessorConstantDescriptor d(factory->to_string_tag_symbol(), toStringTag,
- attribs);
+ DataConstantDescriptor d(factory->to_string_tag_symbol(),
+ factory->NewStringFromAsciiChecked("Module"),
+ attribs);
Map::EnsureDescriptorSlack(map, 1);
map->AppendDescriptor(&d);
« no previous file with comments | « src/accessors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698