Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2410303008: Revert "Use a single file for app snapshots." (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use a single file for app snapshots." This reverts commit 4f8b16df3b3ce9654af03368344706efec247369. Committed: https://github.com/dart-lang/sdk/commit/6839a23240e49b774c7847dc709eec1dfec14c74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -366 lines) Patch
M runtime/bin/dartutils.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/extensions_macos.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/extensions_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +9 lines, -15 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 4 chunks +29 lines, -21 lines 0 comments Download
M runtime/bin/main.cc View 10 chunks +162 lines, -207 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +24 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.h View 3 chunks +3 lines, -12 lines 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +2 lines, -23 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 3 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rmacnak
4 years, 2 months ago (2016-10-13 22:29:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6839a23240e49b774c7847dc709eec1dfec14c74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698