Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: runtime/vm/snapshot.h

Issue 2410303008: Revert "Use a single file for app snapshots." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.h
diff --git a/runtime/vm/snapshot.h b/runtime/vm/snapshot.h
index 020f4485a96efe75537e2ae74bc8ec176c40117a..3f767b8eb25161de71f96942513aa897f156146f 100644
--- a/runtime/vm/snapshot.h
+++ b/runtime/vm/snapshot.h
@@ -750,10 +750,7 @@ class InstructionsWriter : public ZoneAllocated {
int32_t GetObjectOffsetFor(RawObject* raw_object);
- virtual void Write(uint8_t* vmisolate_buffer,
- intptr_t vmisolate_length,
- uint8_t* isolate_buffer,
- intptr_t isolate_length) = 0;
+ virtual void Write() = 0;
virtual intptr_t text_size() = 0;
virtual intptr_t data_size() = 0;
@@ -806,10 +803,7 @@ class AssemblyInstructionsWriter : public InstructionsWriter {
data_size_(0) {
}
- virtual void Write(uint8_t* vmisolate_buffer,
- intptr_t vmisolate_length,
- uint8_t* isolate_buffer,
- intptr_t isolate_length);
+ virtual void Write();
virtual intptr_t text_size() { return text_size_; }
virtual intptr_t data_size() { return data_size_; }
@@ -855,10 +849,7 @@ class BlobInstructionsWriter : public InstructionsWriter {
rodata_blob_stream_(rodata_blob_buffer, alloc, initial_size) {
}
- virtual void Write(uint8_t* vmisolate_buffer,
- intptr_t vmisolate_length,
- uint8_t* isolate_buffer,
- intptr_t isolate_length);
+ virtual void Write();
virtual intptr_t text_size() { return InstructionsBlobSize(); }
virtual intptr_t data_size() { return RodataBlobSize(); }
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698