Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: runtime/vm/snapshot.cc

Issue 2410303008: Revert "Use a single file for app snapshots." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot.h ('k') | tools/testing/dart/compiler_configuration.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index 08cf77ce3a9a7299cf79ad77175343a800e8f584..0062dacd54416bf28618fe500a12d7036128c274 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -704,10 +704,7 @@ static void EnsureIdentifier(char* label) {
}
-void AssemblyInstructionsWriter::Write(uint8_t* vmisolate_buffer,
- intptr_t vmisolate_length,
- uint8_t* isolate_buffer,
- intptr_t isolate_length) {
+void AssemblyInstructionsWriter::Write() {
Thread* thread = Thread::Current();
Zone* zone = thread->zone();
NOT_IN_PRODUCT(TimelineDurationScope tds(thread,
@@ -852,28 +849,10 @@ void AssemblyInstructionsWriter::Write(uint8_t* vmisolate_buffer,
WriteWordLiteralData(*cursor);
}
}
-
-
- assembly_stream_.Print(".globl _kVmIsolateSnapshot\n");
- assembly_stream_.Print(".balign %" Pd ", 0\n", VirtualMemory::PageSize());
- assembly_stream_.Print("_kVmIsolateSnapshot:\n");
- for (intptr_t i = 0; i < vmisolate_length; i++) {
- assembly_stream_.Print(".byte %" Pd "\n", vmisolate_buffer[i]);
- }
-
- assembly_stream_.Print(".globl _kIsolateSnapshot\n");
- assembly_stream_.Print(".balign %" Pd ", 0\n", VirtualMemory::PageSize());
- assembly_stream_.Print("_kIsolateSnapshot:\n");
- for (intptr_t i = 0; i < isolate_length; i++) {
- assembly_stream_.Print(".byte %" Pd "\n", isolate_buffer[i]);
- }
}
-void BlobInstructionsWriter::Write(uint8_t* vmisolate_buffer,
- intptr_t vmisolate_len,
- uint8_t* isolate_buffer,
- intptr_t isolate_length) {
+void BlobInstructionsWriter::Write() {
Thread* thread = Thread::Current();
Zone* zone = thread->zone();
NOT_IN_PRODUCT(TimelineDurationScope tds(thread,
« no previous file with comments | « runtime/vm/snapshot.h ('k') | tools/testing/dart/compiler_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698