Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2410283004: Remove usage of base::ObserverList<T>::Iter::GetNext() in //content. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, Randy Smith (Not in Mondays), nhiroki, kinuko+serviceworker, darin-cc_chromium.org, blink-worker-reviews_chromium.org, loading-reviews_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, mmenke, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of base::ObserverList<T>::Iter::GetNext() in //content. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3 Cr-Commit-Position: refs/heads/master@{#425043}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -34 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +7 lines, -9 lines 1 comment Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
https://codereview.chromium.org/2410283004/diff/1/content/browser/loader/resource_dispatcher_host_impl.cc File content/browser/loader/resource_dispatcher_host_impl.cc (right): https://codereview.chromium.org/2410283004/diff/1/content/browser/loader/resource_dispatcher_host_impl.cc#newcode1036 content/browser/loader/resource_dispatcher_host_impl.cc:1036: handled = true; This is technically redundant given line ...
4 years, 2 months ago (2016-10-12 22:59:05 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-13 15:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410283004/1
4 years, 2 months ago (2016-10-13 15:31:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 15:39:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:44:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3
Cr-Commit-Position: refs/heads/master@{#425043}

Powered by Google App Engine
This is Rietveld 408576698