Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2410283004: Remove usage of base::ObserverList<T>::Iter::GetNext() in //content. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 85968f7103ef00b00c35e06f912f47d222338b4a..e5ec237b5dbb4ad444bd6582c911cef8f843c3e3 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1304,11 +1304,10 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
if (is_swapped_out_ && IPC_MESSAGE_ID_CLASS(message.type()) == InputMsgStart)
return false;
- base::ObserverListBase<RenderViewObserver>::Iterator it(&observers_);
- RenderViewObserver* observer;
- while ((observer = it.GetNext()) != NULL)
- if (observer->OnMessageReceived(message))
+ for (auto& observer : observers_) {
+ if (observer.OnMessageReceived(message))
return true;
+ }
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderViewImpl, message)

Powered by Google App Engine
This is Rietveld 408576698