Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2410283004: Remove usage of base::ObserverList<T>::Iter::GetNext() in //content. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 674728838d4c7781a32a7ab2893c5970e078514b..1e682e733d1be98813dbf845f23bc1c271b1249d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -675,16 +675,16 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
return true;
}
- base::ObserverListBase<WebContentsObserver>::Iterator it(&observers_);
- WebContentsObserver* observer;
if (render_frame_host) {
- while ((observer = it.GetNext()) != NULL)
- if (observer->OnMessageReceived(message, render_frame_host))
+ for (auto& observer : observers_) {
+ if (observer.OnMessageReceived(message, render_frame_host))
return true;
+ }
} else {
- while ((observer = it.GetNext()) != NULL)
- if (observer->OnMessageReceived(message))
+ for (auto& observer : observers_) {
+ if (observer.OnMessageReceived(message))
return true;
+ }
}
// Message handlers should be aware of which

Powered by Google App Engine
This is Rietveld 408576698