Revert of Add gl tests to make sure when a buffer is unmapped, all access path generates an ...

Revert of Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION. (patchset #4 id:60001 of https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION.
>
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053, 654709
Committed: https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773
Cr-Commit-Position: refs/heads/master@{#424398}

[dgn, 2016-10-11 10:03:36]

Created Revert of Add gl tests to make sure when a buffer is unmapped, all
access path generates an INVALID_OPERATION.

[dgn, 2016-10-11 10:04:40]

Description was changed from

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

BUG=654709

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
> 
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053
==========

to

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
> 
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053,654709
==========

[dgn, 2016-10-11 10:05:02]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2016-10-11 10:05:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 10:06:13]

Description was changed from

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
> 
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053,654709
==========

to

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
> 
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053,654709
==========

[commit-bot: I haz the power, 2016-10-11 10:06:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-11 10:07:53]

Description was changed from

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
> 
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053,654709
==========

to

==========
Revert of Add gl tests to make sure when a buffer is unmapped, all access path
generates an INVALID_OPERATION. (patchset #4 id:60001 of
https://codereview.chromium.org/2399113003/ )

Reason for revert:
The new tests have been crashing since they landed.

Original issue's description:
> Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.
>
> BUG=429053
> TEST=gl_tests
> R=vmiura@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
> Cr-Commit-Position: refs/heads/master@{#424238}

TBR=vmiura@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429053,654709

Committed: https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773
Cr-Commit-Position: refs/heads/master@{#424398}
==========

[commit-bot: I haz the power, 2016-10-11 10:07:53]

Patchset 1 (id:??) landed as
https://crrev.com/0d0935bd4971f94fddc7c6fdd266bfdfec3e3773
Cr-Commit-Position: refs/heads/master@{#424398}

[Ken Russell (switch to Gerrit), 2016-10-11 16:03:20]

On 2016/10/11 10:03:36, dgn wrote:
> Created Revert of Add gl tests to make sure when a buffer is unmapped, all
> access path generates an INVALID_OPERATION.

Could you please provide a link to at least one of the failing builds or bots? I
don't see evidence of these crashes on
https://build.chromium.org/p/chromium.gpu/console , digging in to several bots.

[Ken Russell (switch to Gerrit), 2016-10-11 16:15:11]

On 2016/10/11 16:03:20, Ken Russell wrote:
> On 2016/10/11 10:03:36, dgn wrote:
> > Created Revert of Add gl tests to make sure when a buffer is unmapped, all
> > access path generates an INVALID_OPERATION.
> 
> Could you please provide a link to at least one of the failing builds or bots?
I
> don't see evidence of these crashes on
> https://build.chromium.org/p/chromium.gpu/console , digging in to several
bots.

Sorry, I didn't see the linked bug http://crbug.com/654709 .

[dgn, 2016-10-11 16:17:06]

On 2016/10/11 16:03:20, Ken Russell wrote:
> On 2016/10/11 10:03:36, dgn wrote:
> > Created Revert of Add gl tests to make sure when a buffer is unmapped, all
> > access path generates an INVALID_OPERATION.
> 
> Could you please provide a link to at least one of the failing builds or bots?
I
> don't see evidence of these crashes on
> https://build.chromium.org/p/chromium.gpu/console , digging in to several
bots.

Ah the issue link is not very visible it's true. I added the info on
https://crbug.com/654709


Example builder link with the failure:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20L...

Failure summary:

failures:
ES3MapBufferRangeTest.TexImageAndSubImage3D
ES3MapBufferRangeTest.ReadPixels
ES3MapBufferRangeTest.DrawArraysAndInstanced
ES3MapBufferRangeTest.DrawElementsAndInstanced
ES3MapBufferRangeTest.TransformFeedback
ES3MapBufferRangeTest.TexImageAndSubImage2D

ES3MapBufferRangeTest.DrawArraysAndInstancedUNKNOWN
OK (0 tests)
[CRASH] ES3MapBufferRangeTest.DrawElementsAndInstanced:
[ RUN      ] ES3MapBufferRangeTest.DrawElementsAndInstanced
[ERROR:context_group.cc(390)] ContextGroup::Initialize failed because maximum
vertex output components is too small (0, should be 64).
[ CRASHED      ]

(and same thing for all the others.)


Symbolised stack trace:
-----------------------------------------------------

signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 32762 (st:test_process)
pid: 32762, tid: 32762, name: st:test_process  >>>
org.chromium.native_test:test_process <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
     r0 00000000  r1 00008b31  r2 000000ff  r3 00000014
     r4 00008b31  r5 b6dfddd4  r6 b89050f8  r7 be9f8790
     r8 be9f8c58  r9 b6dfddd4  sl b89889a0  fp be9f8cf0
     ip a5f6ed00  sp be9f8790  lr a50b7c75  pc a50b7c76

Stack Trace:
  RELADDR   FUNCTION                                                            
                                                                                
                                          FILE:LINE
  00180c76  GLES2CreateShader+12                                                
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/client/gles2_c_lib_autogen.h:240
  000e78d3  GLTestHelper::CompileShader(unsigned int, char const*)+14           
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:90
  000e824b  GLTestHelper::LoadShader(unsigned int, char const*)+22              
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:100
  000e846b  GLTestHelper::LoadProgram(char const*, char const*)+14              
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_test_utils.cc:151
  000e056b  gpu::ES3MapBufferRangeTest::SetupSimpleProgram(int*)+22             
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:46
  000e06c3 
gpu::ES3MapBufferRangeTest_DrawArraysAndInstanced_Test::TestBody()+66           
                                                                                
                             
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:97
  0093c62b  testing::Test::Run()+106                                            
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2475
  0093c769  testing::TestInfo::Run()+240                                        
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2656
  0093c7f5  testing::TestCase::Run()+112                                        
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2774
  0093f469  testing::internal::UnitTestImpl::RunAllTests()+440                  
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:4647
  v------>  bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) 
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:2458
  009389b1  testing::UnitTest::Run()+96                                         
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/src/gtest.cc:4258
  v------>  RUN_ALL_TESTS()                                                     
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/gtest/include/gtest/gtest.h:2237
  0091d6f1  base::TestSuite::Run()+84                                           
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/base/test/test_suite.cc:246
  000e8883  (anonymous namespace)::RunHelper(base::TestSuite*)+130              
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_tests_main.cc:41
  00929b31  base::internal::RunMixin<base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> >::Run() const+72   
                                                              
/b/c/b/Android_arm_Builder__dbg_/src/base/callback.h:64
  v------>  LaunchUnitTestsInternal                                             
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/base/test/launcher/unit_test_launcher.cc:186
  00929eb9  base::LaunchUnitTestsSerially(int, char**, base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)+48          
                                            
/b/c/b/Android_arm_Builder__dbg_/src/base/test/launcher/unit_test_launcher.cc:469
  000b61c7  main+122                                                            
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/gpu/command_buffer/tests/gl_tests_main.cc:59
  v------>  RunTests                                                            
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/testing/android/native_test/native_test_launcher.cc:136
  008f867b  Java_org_chromium_native_1test_NativeTest_nativeRunTests+650        
                                                                                
                                         
/b/c/b/Android_arm_Builder__dbg_/src/out/Debug/gen/testing/android/native_test/native_test_jni_headers/testing/jni/NativeTest_jni.h:56
  0001d4d1  <unknown>                                                           
                                                                                
                                         
/data/dalvik-cache/arm/data@app@org.chromium.native_test-2@base.apk@classes.dex