Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Issue 2410023002: Revert of Add gl tests to make sure when a buffer is unmapped, all access path generates an ... (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/program_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
index 05fbcd89b56fdd2bcd49c62c371bc4f9e47f3399..6b763f614877b8fa1e89a7e6cd3a4ec69fd7500c 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
@@ -1488,6 +1488,67 @@
EXPECT_EQ(GL_INVALID_ENUM, GetGLError());
}
+TEST_P(GLES3DecoderTest, TransformFeedbackStates) {
+ BeginTransformFeedback begin_cmd;
+ begin_cmd.Init(GL_POINTS);
+ EndTransformFeedback end_cmd;
+ end_cmd.Init();
+ PauseTransformFeedback pause_cmd;
+ pause_cmd.Init();
+ ResumeTransformFeedback resume_cmd;
+ resume_cmd.Init();
+
+ // Before Begin: Pause, Resume, and End is invalid.
+ EXPECT_EQ(error::kNoError, ExecuteCmd(end_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ EXPECT_EQ(error::kNoError, ExecuteCmd(pause_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ EXPECT_EQ(error::kNoError, ExecuteCmd(resume_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ // Begin
+ EXPECT_CALL(*gl_, BeginTransformFeedback(GL_POINTS))
+ .Times(1)
+ .RetiresOnSaturation();
+ EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+
+ // Begin again is invalid.
+ EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ // Before Pause: Resume is invalid.
+ EXPECT_EQ(error::kNoError, ExecuteCmd(resume_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ // Pause
+ EXPECT_CALL(*gl_, PauseTransformFeedback())
+ .Times(1)
+ .RetiresOnSaturation();
+ EXPECT_EQ(error::kNoError, ExecuteCmd(pause_cmd));
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+
+ // Pause again is invalid.
+ EXPECT_EQ(error::kNoError, ExecuteCmd(pause_cmd));
+ EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+
+ // Resume
+ EXPECT_CALL(*gl_, ResumeTransformFeedback())
+ .Times(1)
+ .RetiresOnSaturation();
+ EXPECT_EQ(error::kNoError, ExecuteCmd(resume_cmd));
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+
+ // End
+ EXPECT_CALL(*gl_, EndTransformFeedback())
+ .Times(1)
+ .RetiresOnSaturation();
+ EXPECT_EQ(error::kNoError, ExecuteCmd(end_cmd));
+ EXPECT_EQ(GL_NO_ERROR, GetGLError());
+}
+
class GLES2DecoderDoCommandsTest : public GLES2DecoderTest {
public:
GLES2DecoderDoCommandsTest() {
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/program_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698