third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py - Issue 2409903002: When rebaselining testharness tests with new all-PASS results, remove the baseline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

Issue 2409903002: When rebaselining testharness tests with new all-PASS results, remove the baseline. (Closed)

Patch Set: Undo docstrings that no longer apply Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/check-testharness-expected-pass ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

index ccebc371c4605b6cbf660c5269c08b3ab5a93c23..56bc0ee113d9566dfb3a488dced7c4e0799c32da 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py

@@ -10,6 +10,13 @@ TESTHARNESSREPORT_HEADER = 'This is a testharness.js-based test.'

TESTHARNESSREPORT_FOOTER = 'Harness: the test ran to completion.'

+def is_all_pass_testharness_result(content_text):

+ """Returns whether |content_text| is a testharness result that only contains PASS lines."""

+ return (is_testharness_output(content_text) and

+ is_testharness_output_passing(content_text) and

+ not is_testharness_output_with_console_errors_or_warnings(content_text))

def is_testharness_output(content_text):

"""Returns whether the content_text in parameter is a testharness output."""