Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

Issue 2409903002: When rebaselining testharness tests with new all-PASS results, remove the baseline. (Closed)
Patch Set: Undo docstrings that no longer apply Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
diff --git a/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass b/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
index 82b070f8aba9efeed4e0286219250552642c88d5..63a4ff2b75293b371a0d8633da04e506173d19be 100755
--- a/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
+++ b/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
@@ -12,18 +12,15 @@ infrastructure will read the output of testharness.js tests if there is no
expected files."""
-import fileinput
import sys
-from webkitpy.layout_tests.models import testharness_results
+from webkitpy.layout_tests.models.testharness_results import is_all_pass_testharness_result
paths = []
for path in sys.argv[1:]:
content = open(path, 'r').read()
- if (testharness_results.is_testharness_output(content) and
- testharness_results.is_testharness_output_passing(content) and
- not testharness_results.is_testharness_output_with_console_errors_or_warnings(content)):
+ if is_all_pass_testharness_result(content):
paths.append(path)
if len(paths) > 0:
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698