Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

Issue 2409903002: When rebaselining testharness tests with new all-PASS results, remove the baseline. (Closed)
Patch Set: Undo docstrings that no longer apply Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
index 160f09174483d517773e19fb41e1e2e5c513ef89..7cb22aed087f23f48c9c2e0f715da19f4d27b766 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
@@ -9,6 +9,26 @@ from webkitpy.layout_tests.models import testharness_results
class TestHarnessResultCheckerTest(unittest.TestCase):
+ # TODO(qyearsley): Reformat this unit test and split up test methods to improve readability.
+
+ def is_all_pass_testharness_result(self):
+ test_data = [
+ {
+ 'content': 'This is a testharness.js-based test.\nCONSOLE WARNING: This is a warning.\nTest ran to completion.',
+ 'result': False
+ },
+ {
+ 'content': 'This is a testharness.js-based test.\n PASS: foo bar \n Harness: the test ran to completion.',
+ 'result': True
+ },
+ {
+ 'content': 'This is a testharness.js-based test.\n PASS: foo bar \nFAIL \n Harness: the test ran to completion.',
+ 'result': False
+ },
+ ]
+ for data in test_data:
+ self.assertEqual(data['result'], testharness_results.is_all_pass_testharness_result(data['content']))
+
def test_is_testharness_output(self):
test_data = [
{

Powered by Google App Engine
This is Rietveld 408576698