chrome/renderer/content_settings_observer.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/content_settings_observer.cc

diff --git a/chrome/renderer/content_settings_observer.cc b/chrome/renderer/content_settings_observer.cc

index 160996ca21c15429950232e44bd0c15d2095795e..8956127086f4c5a351f448d2c119059ed687a5c9 100644

--- a/chrome/renderer/content_settings_observer.cc

+++ b/chrome/renderer/content_settings_observer.cc

@@ -521,7 +521,7 @@ bool ContentSettingsObserver::IsWhitelistedForContentSettings() const {

bool ContentSettingsObserver::IsWhitelistedForContentSettings(

const WebSecurityOrigin& origin,

const GURL& document_url) {

- if (document_url == GURL(content::kUnreachableWebDataURL))

+ if (document_url.spec() == content::kUnreachableWebDataURL)

return true;

if (origin.isUnique())