Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5070)

Unified Diff: chrome/browser/ui/webui/uber/uber_ui.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/uber/uber_ui.cc
diff --git a/chrome/browser/ui/webui/uber/uber_ui.cc b/chrome/browser/ui/webui/uber/uber_ui.cc
index 886fb6273e39627beebf7063b6f6db38880300bc..92ffe43629c8023d2e01dd9859c1d5fbbe912a9e 100644
--- a/chrome/browser/ui/webui/uber/uber_ui.cc
+++ b/chrome/browser/ui/webui/uber/uber_ui.cc
@@ -146,11 +146,11 @@ void SubframeLogger::DidCommitProvisionalLoadForFrame(
content::RenderFrameHost* render_frame_host,
const GURL& url,
ui::PageTransition transition_type) {
- if (url == GURL(chrome::kChromeUIExtensionsFrameURL) ||
- url == GURL(chrome::kChromeUIHelpFrameURL) ||
- url == GURL(chrome::kChromeUIHistoryFrameURL) ||
- url == GURL(chrome::kChromeUISettingsFrameURL) ||
- url == GURL(chrome::kChromeUIUberFrameURL)) {
+ if (url.spec() == chrome::kChromeUIExtensionsFrameURL ||
+ url.spec() == chrome::kChromeUIHelpFrameURL ||
+ url.spec() == chrome::kChromeUIHistoryFrameURL ||
+ url.spec() == chrome::kChromeUISettingsFrameURL ||
+ url.spec() == chrome::kChromeUIUberFrameURL) {
webui::LogWebUIUrl(url);
}
}

Powered by Google App Engine
This is Rietveld 408576698