chrome/renderer/extensions/resource_request_policy.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/resource_request_policy.cc

diff --git a/chrome/renderer/extensions/resource_request_policy.cc b/chrome/renderer/extensions/resource_request_policy.cc

index 449560595a986898487a46cbaf8d70dce5f894d9..74d3d27b70c138439c2d62dbc24f791c3b5cc851 100644

--- a/chrome/renderer/extensions/resource_request_policy.cc

+++ b/chrome/renderer/extensions/resource_request_policy.cc

@@ -94,7 +94,7 @@ bool ResourceRequestPolicy::CanRequestResource(

!ui::PageTransitionIsWebTriggerable(transition_type);

// - unreachable web page error page (to allow showing the icon of the

// unreachable app on this page)

- bool is_error_page = frame_url == GURL(content::kUnreachableWebDataURL);

+ bool is_error_page = frame_url.spec() == content::kUnreachableWebDataURL;

if (!is_empty_origin && !is_own_resource &&

!is_dev_tools && !transition_allowed && !is_error_page) {