chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 4a7ada3dedaa62b37c4bcc9fa555c01e66fca406..d2a46dc9575b32bfa5ba6473c25952a2a17d3cda 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -983,7 +983,7 @@ void StartupBrowserCreatorImpl::AddStartupURLs(

// behavior is desired because completing or skipping the sync promo

// causes a redirect to the NTP.

if (!startup_urls->empty() &&

- startup_urls->at(0) == GURL(chrome::kChromeUINewTabURL))

+ startup_urls->at(0).spec() == chrome::kChromeUINewTabURL)

startup_urls->at(0) = sync_promo_url;

else

startup_urls->insert(startup_urls->begin(), sync_promo_url);