Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/singleton_tabs.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/app_controller_mac.mm ('K') | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/singleton_tabs.cc
diff --git a/chrome/browser/ui/singleton_tabs.cc b/chrome/browser/ui/singleton_tabs.cc
index 042f85ff071ccb64edfd13e5d99ebf6510a38ce0..0a931b7f50730389ac196b7d83185db080666caa 100644
--- a/chrome/browser/ui/singleton_tabs.cc
+++ b/chrome/browser/ui/singleton_tabs.cc
@@ -50,9 +50,9 @@ void ShowSingletonTabOverwritingNTP(Browser* browser,
browser->tab_strip_model()->GetActiveWebContents();
if (contents) {
const GURL& contents_url = contents->GetURL();
- if ((contents_url == GURL(kChromeUINewTabURL) ||
+ if ((contents_url.spec() == kChromeUINewTabURL ||
search::IsInstantNTP(contents) ||
- contents_url == GURL(url::kAboutBlankURL)) &&
+ contents_url.spec() == url::kAboutBlankURL) &&
GetIndexOfSingletonTab(&local_params) < 0) {
local_params.disposition = WindowOpenDisposition::CURRENT_TAB;
}
« chrome/browser/app_controller_mac.mm ('K') | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698