Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/data_usage/data_use_ui_tab_model.cc ('k') | chrome/browser/history/history_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 9979e7055496cabbbe79807a64fbe15d35956f40..b2fdb450d4bacb8e3a3ff302889dba3e40814f7e 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -716,7 +716,7 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
[self openUrls:urls];
if (startupIndex != TabStripModel::kNoTab &&
- startupContent->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL)) {
+ startupContent->GetVisibleURL().spec() == chrome::kChromeUINewTabURL) {
brettw 2016/10/14 18:01:24 Is the visible URL always guaranteed to be valid?
Charlie Harrison 2016/10/14 18:13:55 You're right, it can be invalid (in a whole bunch
browser->tab_strip_model()->CloseWebContentsAt(startupIndex,
TabStripModel::CLOSE_NONE);
}
« no previous file with comments | « chrome/browser/android/data_usage/data_use_ui_tab_model.cc ('k') | chrome/browser/history/history_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698