Compare GURLs to kUrlConstants with .spec() and string equality

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 698 matching lines @@
   content::WebContents* startupContent = NULL;
 
   if (browser && browser->tab_strip_model()->count() == 1) {
     startupIndex = browser->tab_strip_model()->active_index();
     startupContent = browser->tab_strip_model()->GetActiveWebContents();
   }
 
   [self openUrls:urls];
 
   if (startupIndex != TabStripModel::kNoTab &&
-      startupContent->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL)) {
+      startupContent->GetVisibleURL().spec() == chrome::kChromeUINewTabURL) {

[brettw, 2016/10/14 18:01:24]

Is the visible URL always guaranteed to be valid? What happens if you have an
invalid URL on the command line?

[Charlie Harrison, 2016/10/14 18:13:55]

You're right, it can be invalid (in a whole bunch of different ways).

     browser->tab_strip_model()->CloseWebContentsAt(startupIndex,
         TabStripModel::CLOSE_NONE);
   }
 }
 
 // This is called after profiles have been loaded and preferences registered.
 // It is safe to access the default profile here.
 - (void)applicationDidFinishLaunching:(NSNotification*)notify {
   MacStartupProfiler::GetInstance()->Profile(
       MacStartupProfiler::DID_FINISH_LAUNCHING);
@@ skipping 948 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac