chrome/browser/history/history_utils.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_utils.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_utils.cc

diff --git a/chrome/browser/history/history_utils.cc b/chrome/browser/history/history_utils.cc

index cbb66d4f35e3a1e1c3f3e8ae12428ebfb2a13931..1ea9680e1cec710d744725d739e35f8d0ad97097 100644

--- a/chrome/browser/history/history_utils.cc

+++ b/chrome/browser/history/history_utils.cc

@@ -25,7 +25,7 @@ bool CanAddURLToHistory(const GURL& url) {

url.SchemeIs(dom_distiller::kDomDistillerScheme))

return false;

- if (url == GURL(url::kAboutBlankURL))

+ if (url.spec() == url::kAboutBlankURL)

return false;

return true;