Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2408353003: Add hasViewportRule() flag to StyleSheetContents. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add hasViewportRule() flag to StyleSheetContents. This is a pre-requisite for collecting viewport rules before generating the RuleSet. The RuleSet contents depends on media query evaluation, which in turn depends on viewport size resolution, which means we are currently may generate the RuleSet, and recalculate style, twice in the presence of both @media and @viewport. This CL is split out from [1] which in turn is split out from [2]. [1] https://codereview.chromium.org/2405143003/ [2] https://codereview.chromium.org/1913833002/ R=timloh@chromium.org BUG=463098 Committed: https://crrev.com/d0fae7951dff76665a0fbe4c26abb1a94b87072f Cr-Commit-Position: refs/heads/master@{#425273}

Patch Set 1 #

Patch Set 2 : CORE_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/StyleRule.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContentsTest.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
rune
ptal
4 years, 2 months ago (2016-10-12 11:28:06 UTC) #2
Timothy Loh
On 2016/10/12 11:28:06, rune wrote: > ptal lgtm
4 years, 2 months ago (2016-10-14 04:29:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408353003/20001
4 years, 2 months ago (2016-10-14 07:21:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 08:30:17 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:32:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0fae7951dff76665a0fbe4c26abb1a94b87072f
Cr-Commit-Position: refs/heads/master@{#425273}

Powered by Google App Engine
This is Rietveld 408576698