Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2405143003: Separate @viewport from other RuleSet construction. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, kenneth.christiansen, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate @viewport from other RuleSet construction. Which rules goes into the RuleSet for a stylesheet depends on the evaluation of the media queries. The evaluation of the media queries depends on @viewport rules. We have been collecting @viewport rules along with other rules which means we have been evaluating media queries as if the viewport rules are not there, and re-construct the RuleSet afterwards if the @viewport rules caused the viewport to change, hence caused viewport dependent media queries to change. The default stylesheets for viewport rules no longer create RuleSets as they are not needed. BUG=567021

Patch Set 1 #

Patch Set 2 : Oilpan. #

Patch Set 3 : Oilpan. #

Patch Set 4 : Rebased #

Patch Set 5 : Missing resolve() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -147 lines) Patch
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 3 chunks +14 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 4 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetList.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.h View 2 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 5 chunks +74 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 2 3 4 2 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 2 3 6 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 2 3 6 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 2 3 chunks +69 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (17 generated)
rune
The CQ bit was checked by rune@opera.com to run a CQ dry run
4 years, 2 months ago (2016-10-11 15:11:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405143003/1
4 years, 2 months ago (2016-10-11 15:11:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-11 15:32:36 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/171725)
4 years, 2 months ago (2016-10-11 15:32:37 UTC) #4
rune
The CQ bit was checked by rune@opera.com to run a CQ dry run
4 years, 2 months ago (2016-10-12 10:48:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405143003/40001
4 years, 2 months ago (2016-10-12 10:48:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-12 11:00:18 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/215163) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 2 months ago (2016-10-12 11:00:19 UTC) #8
rune
The CQ bit was checked by rune@opera.com to run a CQ dry run
4 years, 2 months ago (2016-10-12 11:10:16 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405143003/60001
4 years, 2 months ago (2016-10-12 11:10:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-12 12:26:12 UTC) #11
commit-bot: I haz the power
Dry run: Exceeded global retry quota
4 years, 2 months ago (2016-10-12 12:26:13 UTC) #12
rune
The CQ bit was checked by rune@opera.com to run a CQ dry run
4 years, 2 months ago (2016-10-13 08:21:09 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405143003/80001
4 years, 2 months ago (2016-10-13 08:21:21 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-13 09:30:00 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-13 09:30:02 UTC) #16
rune
4 years, 2 months ago (2016-10-18 17:06:34 UTC) #17
Description was changed from

==========
Separate @viewport from other RuleSet construction.

Which rules goes into the RuleSet for a stylesheet depends on the
evaluation of the media queries. The evaluation of the media queries
depends on @viewport rules.

We have been collecting @viewport rules along with other rules which
means we have been evaluating media queries as if the viewport rules
are not there, and re-construct the RuleSet afterwards if the @viewport
rules caused the viewport to change, hence caused viewport dependent
media queries to change.

The default stylesheets for viewport rules no longer create RuleSets as
they are not needed.

BUG=567021
==========

to

==========
Separate @viewport from other RuleSet construction.

Which rules goes into the RuleSet for a stylesheet depends on the
evaluation of the media queries. The evaluation of the media queries
depends on @viewport rules.

We have been collecting @viewport rules along with other rules which
means we have been evaluating media queries as if the viewport rules
are not there, and re-construct the RuleSet afterwards if the @viewport
rules caused the viewport to change, hence caused viewport dependent
media queries to change.

The default stylesheets for viewport rules no longer create RuleSets as
they are not needed.

BUG=567021
==========

Powered by Google App Engine
This is Rietveld 408576698