Don't generate RuleSets for viewport UA sheets.

Don't generate RuleSets for viewport UA sheets.

Start collecting UA @viewport rules from the StyleSheetContents instead
of the RuleSet. The reason is that we need to collect viewport rules
before creating the RuleSet in order to use the correct actual viewport
for evaluating media queries. This is split out from [1].

Also introducing a separate MediaQueryEvaluator in the
ViewportStyleResolver which should eventually be based on the initial
viewport and not the actual viewport as described in the CSS Device
Adaptation spec.

[1] https://codereview.chromium.org/2405143003

R=timloh@chromium.org
BUG=463098
Committed: https://crrev.com/4b7a7561cf670c265fbeccaa1a279db7e18686b6
Cr-Commit-Position: refs/heads/master@{#425284}

[rune, 2016-10-13 12:13:06]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 12:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-10-13 12:15:10]

ptal

[commit-bot: I haz the power, 2016-10-13 13:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 13:04:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-10-13 21:08:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:24:45]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-10-14 04:27:25]

lgtm

https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
(right):

https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp:100: if
(!rule->isMediaRule())
Also needs to recurse on @supports rules (this is eventually going to be used to
author sheets, right?)

[rune, 2016-10-14 07:59:02]

https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
(right):

https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp:100: if
(!rule->isMediaRule())
On 2016/10/14 04:27:24, Timothy Loh wrote:
> Also needs to recurse on @supports rules (this is eventually going to be used
to
> author sheets, right?)

Oh, yes. Well spotted. And @import rules too, if their stylesheets contain
@viewport rules.

[rune, 2016-10-14 08:16:37]

On 2016/10/14 07:59:02, rune wrote:
>
https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
> (right):
> 
>
https://codereview.chromium.org/2410283005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp:100: if
> (!rule->isMediaRule())
> On 2016/10/14 04:27:24, Timothy Loh wrote:
> > Also needs to recurse on @supports rules (this is eventually going to be
used
> to
> > author sheets, right?)
> 
> Oh, yes. Well spotted. And @import rules too, if their stylesheets contain
> @viewport rules.

The @import rules are not part of the childRules pass, so I'll defer that to
author sheet handling.

[rune, 2016-10-14 08:39:50]

The CQ bit was checked by rune@opera.com

[rune, 2016-10-14 08:39:51]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2410283005/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-14 08:40:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 09:57:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-14 10:00:03]

Description was changed from

==========
Don't generate RuleSets for viewport UA sheets.

Start collecting UA @viewport rules from the StyleSheetContents instead
of the RuleSet. The reason is that we need to collect viewport rules
before creating the RuleSet in order to use the correct actual viewport
for evaluating media queries. This is split out from [1].

Also introducing a separate MediaQueryEvaluator in the
ViewportStyleResolver which should eventually be based on the initial
viewport and not the actual viewport as described in the CSS Device
Adaptation spec.

[1] https://codereview.chromium.org/2405143003

R=timloh@chromium.org
BUG=463098
==========

to

==========
Don't generate RuleSets for viewport UA sheets.

Start collecting UA @viewport rules from the StyleSheetContents instead
of the RuleSet. The reason is that we need to collect viewport rules
before creating the RuleSet in order to use the correct actual viewport
for evaluating media queries. This is split out from [1].

Also introducing a separate MediaQueryEvaluator in the
ViewportStyleResolver which should eventually be based on the initial
viewport and not the actual viewport as described in the CSS Device
Adaptation spec.

[1] https://codereview.chromium.org/2405143003

R=timloh@chromium.org
BUG=463098

Committed: https://crrev.com/4b7a7561cf670c265fbeccaa1a279db7e18686b6
Cr-Commit-Position: refs/heads/master@{#425284}
==========

[commit-bot: I haz the power, 2016-10-14 10:00:04]

Patchset 4 (id:??) landed as
https://crrev.com/4b7a7561cf670c265fbeccaa1a279db7e18686b6
Cr-Commit-Position: refs/heads/master@{#425284}