Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2408103002: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Don't count CallIC calls as patching ICs. In fullcodegen we used to count CallICs as patching ICs, and thus the heuristics are currently off by the number of calls in a code object. R=mvstanton@chromium.org Committed: https://crrev.com/001926cdeca5fe1882cb017c102ffb8bfc42dd04 Cr-Commit-Position: refs/heads/master@{#40163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-11 10:57:58 UTC) #1
mvstanton
lgtm
4 years, 2 months ago (2016-10-11 11:07:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408103002/1
4 years, 2 months ago (2016-10-11 11:07:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 11:24:09 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:24:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/001926cdeca5fe1882cb017c102ffb8bfc42dd04
Cr-Commit-Position: refs/heads/master@{#40163}

Powered by Google App Engine
This is Rietveld 408576698