Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2408103002: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2266 matching lines...) Expand 10 before | Expand all | Expand 10 after
2277 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS); 2277 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS);
2278 SetCallPosition(expr, expr->tail_call_mode()); 2278 SetCallPosition(expr, expr->tail_call_mode());
2279 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2279 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2280 if (FLAG_trace) { 2280 if (FLAG_trace) {
2281 __ CallRuntime(Runtime::kTraceTailCall); 2281 __ CallRuntime(Runtime::kTraceTailCall);
2282 } 2282 }
2283 // Update profiling counters before the tail call since we will 2283 // Update profiling counters before the tail call since we will
2284 // not return to this function. 2284 // not return to this function.
2285 EmitProfilingCounterHandlingForReturnSequence(true); 2285 EmitProfilingCounterHandlingForReturnSequence(true);
2286 } 2286 }
2287 Handle<Code> ic = 2287 Handle<Code> code =
2288 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2288 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
2289 .code(); 2289 .code();
2290 __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot())); 2290 __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot()));
2291 __ Peek(x1, (arg_count + 1) * kXRegSize); 2291 __ Peek(x1, (arg_count + 1) * kXRegSize);
2292 // Don't assign a type feedback id to the IC, since type feedback is provided 2292 __ Call(code, RelocInfo::CODE_TARGET);
2293 // by the vector above.
2294 CallIC(ic);
2295 OperandStackDepthDecrement(arg_count + 1); 2293 OperandStackDepthDecrement(arg_count + 1);
2296 2294
2297 RecordJSReturnSite(expr); 2295 RecordJSReturnSite(expr);
2298 RestoreContext(); 2296 RestoreContext();
2299 context()->DropAndPlug(1, x0); 2297 context()->DropAndPlug(1, x0);
2300 } 2298 }
2301 2299
2302 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2300 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2303 int arg_count = expr->arguments()->length(); 2301 int arg_count = expr->arguments()->length();
2304 ASM_LOCATION("FullCodeGenerator::EmitResolvePossiblyDirectEval"); 2302 ASM_LOCATION("FullCodeGenerator::EmitResolvePossiblyDirectEval");
(...skipping 1429 matching lines...) Expand 10 before | Expand all | Expand 10 after
3734 } 3732 }
3735 3733
3736 return INTERRUPT; 3734 return INTERRUPT;
3737 } 3735 }
3738 3736
3739 3737
3740 } // namespace internal 3738 } // namespace internal
3741 } // namespace v8 3739 } // namespace v8
3742 3740
3743 #endif // V8_TARGET_ARCH_ARM64 3741 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698