Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2408103002: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 2373 matching lines...) Expand 10 before | Expand all | Expand 10 after
2384 // Record source position of the IC call. 2384 // Record source position of the IC call.
2385 SetCallPosition(expr, expr->tail_call_mode()); 2385 SetCallPosition(expr, expr->tail_call_mode());
2386 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2386 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2387 if (FLAG_trace) { 2387 if (FLAG_trace) {
2388 __ CallRuntime(Runtime::kTraceTailCall); 2388 __ CallRuntime(Runtime::kTraceTailCall);
2389 } 2389 }
2390 // Update profiling counters before the tail call since we will 2390 // Update profiling counters before the tail call since we will
2391 // not return to this function. 2391 // not return to this function.
2392 EmitProfilingCounterHandlingForReturnSequence(true); 2392 EmitProfilingCounterHandlingForReturnSequence(true);
2393 } 2393 }
2394 Handle<Code> ic = 2394 Handle<Code> code =
2395 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2395 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
2396 .code(); 2396 .code();
2397 __ li(a3, Operand(SmiFromSlot(expr->CallFeedbackICSlot()))); 2397 __ li(a3, Operand(SmiFromSlot(expr->CallFeedbackICSlot())));
2398 __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); 2398 __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize));
2399 // Don't assign a type feedback id to the IC, since type feedback is provided 2399 __ Call(code, RelocInfo::CODE_TARGET);
2400 // by the vector above.
2401 CallIC(ic);
2402 OperandStackDepthDecrement(arg_count + 1); 2400 OperandStackDepthDecrement(arg_count + 1);
2403 2401
2404 RecordJSReturnSite(expr); 2402 RecordJSReturnSite(expr);
2405 RestoreContext(); 2403 RestoreContext();
2406 context()->DropAndPlug(1, v0); 2404 context()->DropAndPlug(1, v0);
2407 } 2405 }
2408 2406
2409 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2407 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2410 int arg_count = expr->arguments()->length(); 2408 int arg_count = expr->arguments()->length();
2411 // a6: copy of the first argument or undefined if it doesn't exist. 2409 // a6: copy of the first argument or undefined if it doesn't exist.
(...skipping 1267 matching lines...) Expand 10 before | Expand all | Expand 10 after
3679 reinterpret_cast<uint64_t>( 3677 reinterpret_cast<uint64_t>(
3680 isolate->builtins()->OnStackReplacement()->entry())); 3678 isolate->builtins()->OnStackReplacement()->entry()));
3681 return ON_STACK_REPLACEMENT; 3679 return ON_STACK_REPLACEMENT;
3682 } 3680 }
3683 3681
3684 3682
3685 } // namespace internal 3683 } // namespace internal
3686 } // namespace v8 3684 } // namespace v8
3687 3685
3688 #endif // V8_TARGET_ARCH_MIPS64 3686 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698