Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2408083003: Drop [ExperimentalCallbackFunction] (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 2 months ago
Reviewers:
haraken, peria, Yuki
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, cmumford, blink-reviews, jsbell+idb_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [ExperimentalCallbackFunction] The code generator will generate bindings for callback functions by default. Specify [Custom] when hand-written bindings are needed. BUG=648486 Committed: https://crrev.com/5d0ee8a7c7f411bf664af3b87da571f4e09367e4 Cr-Commit-Position: refs/heads/master@{#424401}

Patch Set 1 : Tweak #

Total comments: 4

Patch Set 2 : Update tests and expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -380 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 4 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_types.py View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 5 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterfacePartial.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface5.idl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp View 1 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 16 chunks +26 lines, -51 lines 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.cpp View 1 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
bashi
PTAL Remaining two callbacks (IntersectionObserverCallback and CustomElementConstructor) are not simple callback functions so I think ...
4 years, 2 months ago (2016-10-11 06:57:10 UTC) #5
haraken
LGTM
4 years, 2 months ago (2016-10-11 08:22:32 UTC) #6
bashi
https://codereview.chromium.org/2408083003/diff/20001/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl File third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl (right): https://codereview.chromium.org/2408083003/diff/20001/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl#newcode34 third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl:34: [Custom] callback VoidCallbackFunction = void (); On 2016/10/11 06:57:10, ...
4 years, 2 months ago (2016-10-11 09:15:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408083003/40001
4 years, 2 months ago (2016-10-11 09:15:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-11 10:34:40 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 10:35:59 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5d0ee8a7c7f411bf664af3b87da571f4e09367e4
Cr-Commit-Position: refs/heads/master@{#424401}

Powered by Google App Engine
This is Rietveld 408576698