third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2408083003: Drop [ExperimentalCallbackFunction]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2408083003: Drop [ExperimentalCallbackFunction] (Closed)

Patch Set: Update tests and expectations Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index 6cd76a9da981ed84136f6d7a51a662148246695c..0cd28d2b85a83eb34941ddd0b0458137586d9572 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -1118,7 +1118,7 @@ def resolution_tests_methods(effective_overloads):

# same thing.

try:

method = next(method for idl_type, method in idl_types_methods

- if idl_type.is_callback_function)

+ if idl_type.is_custom_callback_function)

test = '%s->IsFunction()' % cpp_value

yield test, method

except StopIteration: