Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

Issue 2408083003: Drop [ExperimentalCallbackFunction] (Closed)
Patch Set: Update tests and expectations Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
index fa778f4b9b018dd7fd2c391aab0510eb3ee8ac0e..e1b4883954e5c10f3c73ad0ee15337a8515420f0 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
@@ -138,7 +138,6 @@ class CodeGeneratorV8Base(CodeGeneratorBase):
if not self.should_generate_code(definitions):
return set()
- IdlType.set_callback_functions(definitions.callback_functions.keys())
# Resolve typedefs
self.typedef_resolver.resolve(definitions, definition_name)
return self.generate_code_internal(definitions, definition_name)
@@ -373,6 +372,8 @@ class CodeGeneratorCallbackFunction(CodeGeneratorBase):
if callback_function_dict['component_dir'] != self.target_component:
continue
callback_function = callback_function_dict['callback_function']
+ if 'Custom' in callback_function.extended_attributes:
+ continue
path = callback_function_dict['full_path']
outputs.update(self.generate_code_internal(callback_function, path))
return outputs

Powered by Google App Engine
This is Rietveld 408576698