Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2408063009: media: Use native DecodeStatus in media mojo interfaces (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
Reviewers:
jrummell, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use native DecodeStatus in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Committed: https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d Cr-Commit-Position: refs/heads/master@{#425193}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -48 lines) Patch
M media/base/decode_status.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_audio_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_video_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +2 lines, -6 lines 0 comments Download
M media/mojo/interfaces/media_types.typemap View 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder_service.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_video_decoder_service.h View 1 chunk +6 lines, -1 line 0 comments Download
M media/mojo/services/mojo_video_decoder_service.cc View 4 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
xhwang
PTAL
4 years, 2 months ago (2016-10-13 19:08:27 UTC) #4
xhwang
dcheng: Another enum typemap CL. mojom OWNERS review please!
4 years, 2 months ago (2016-10-13 19:33:13 UTC) #6
dcheng
LGTM
4 years, 2 months ago (2016-10-13 19:38:25 UTC) #7
jrummell
LGTM w/nit. https://codereview.chromium.org/2408063009/diff/1/media/mojo/common/media_type_converters.cc File media/mojo/common/media_type_converters.cc (right): https://codereview.chromium.org/2408063009/diff/1/media/mojo/common/media_type_converters.cc#newcode44 media/mojo/common/media_type_converters.cc:44: #define ASSERT_ENUM_CLASS_EQ(media_enum, value) \ CodeSearch only shows ...
4 years, 2 months ago (2016-10-13 20:40:20 UTC) #10
xhwang
comments addressed
4 years, 2 months ago (2016-10-13 20:52:12 UTC) #11
xhwang
https://chromiumcodereview.appspot.com/2408063009/diff/1/media/mojo/common/media_type_converters.cc File media/mojo/common/media_type_converters.cc (right): https://chromiumcodereview.appspot.com/2408063009/diff/1/media/mojo/common/media_type_converters.cc#newcode44 media/mojo/common/media_type_converters.cc:44: #define ASSERT_ENUM_CLASS_EQ(media_enum, value) \ On 2016/10/13 20:40:20, jrummell wrote: ...
4 years, 2 months ago (2016-10-13 20:52:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408063009/20001
4 years, 2 months ago (2016-10-13 20:53:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 22:30:50 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 22:32:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d
Cr-Commit-Position: refs/heads/master@{#425193}

Powered by Google App Engine
This is Rietveld 408576698