media: Use native DecodeStatus in media mojo interfaces

media/mojo/services/mojo_video_decoder_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_MOJO_SERVICES_MOJO_VIDEO_DECODER_SERVICE_H_
 #define MEDIA_MOJO_SERVICES_MOJO_VIDEO_DECODER_SERVICE_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 19 matching lines @@
   void Construct(mojom::VideoDecoderClientAssociatedPtrInfo client,
                  mojo::ScopedDataPipeConsumerHandle decoder_buffer_pipe) final;
   void Initialize(mojom::VideoDecoderConfigPtr config,
                   bool low_delay,
                   const InitializeCallback& callback) final;
   void Decode(mojom::DecoderBufferPtr buffer,
               const DecodeCallback& callback) final;
   void Reset(const ResetCallback& callback) final;
 
  private:
+  // Helper methods so that we can bind them with a weak pointer to avoid
+  // running mojom::VideoDecoder callbacks after connection error happens and
+  // |this| is deleted. It's not safe to run the callbacks after a connection
+  // error.
   void OnDecoderInitialized(const InitializeCallback& callback, bool success);
   void OnDecoderDecoded(const DecodeCallback& callback, DecodeStatus status);
+  void OnDecoderReset(const ResetCallback& callback);
+
   void OnDecoderOutput(const scoped_refptr<VideoFrame>& frame);
-  void OnDecoderReset(const ResetCallback& callback);
 
   mojom::VideoDecoderClientAssociatedPtr client_;
   std::unique_ptr<MojoDecoderBufferReader> mojo_decoder_buffer_reader_;
 
   MojoMediaClient* mojo_media_client_;
   std::unique_ptr<media::VideoDecoder> decoder_;
 
   base::WeakPtr<MojoVideoDecoderService> weak_this_;
   base::WeakPtrFactory<MojoVideoDecoderService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MojoVideoDecoderService);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_MOJO_SERVICES_MOJO_VIDEO_DECODER_SERVICE_H_