Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2407243002: [css-grid] Use min-size instead of min-content for intrinsic maximums (Closed)

Created:
4 years, 2 months ago by svillar
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Use min-size instead of min-content for intrinsic maximums This was recently modified in the specs, see https://hg.csswg.org/drafts/diff/575fb847e29d/css-grid/Overview.bs. We're talking specifically about the last change. As it can be seen, in order to resolve the intrinsic max track sizing functions, we should use the min-size contribution (It used to be min-content contribution). BUG=654737 Committed: https://crrev.com/9f99de1e0759b02149b2840830d7327e09b58079 Cr-Commit-Position: refs/heads/master@{#424527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html View 6 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html View 5 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
svillar
4 years, 2 months ago (2016-10-11 14:06:11 UTC) #2
eae
LGTM
4 years, 2 months ago (2016-10-11 15:44:01 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2411673003 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-11 15:44:23 UTC) #6
cbiesinger
lgtm
4 years, 2 months ago (2016-10-11 18:48:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407243002/1
4 years, 2 months ago (2016-10-11 18:49:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 20:21:50 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:24:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f99de1e0759b02149b2840830d7327e09b58079
Cr-Commit-Position: refs/heads/master@{#424527}

Powered by Google App Engine
This is Rietveld 408576698