Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html

Issue 2407243002: [css-grid] Use min-size instead of min-content for intrinsic maximums (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <link href="resources/grid.css" rel="stylesheet"> 3 <link href="resources/grid.css" rel="stylesheet">
4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet"> 4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet">
5 5
6 <style> 6 <style>
7 7
8 .item { 8 .item {
9 font: 10px/1 Ahem; 9 font: 10px/1 Ahem;
10 background: cyan; 10 background: cyan;
(...skipping 28 matching lines...) Expand all
39 .gridMinContent { grid-template: 20px / minmax(0px, min-content) 5px; } 39 .gridMinContent { grid-template: 20px / minmax(0px, min-content) 5px; }
40 .gridMaxContent { grid-template: 20px / 5px minmax(0px, max-content); } 40 .gridMaxContent { grid-template: 20px / 5px minmax(0px, max-content); }
41 .gridMinMaxContent { grid-template: 20px / minmax(0px, min-content) 5% minmax(0p x, max-content); } 41 .gridMinMaxContent { grid-template: 20px / minmax(0px, min-content) 5% minmax(0p x, max-content); }
42 .gridAutoMinContent { grid-template: 20px / minmax(0px, auto) 5px minmax(0px, mi n-content); } 42 .gridAutoMinContent { grid-template: 20px / minmax(0px, auto) 5px minmax(0px, mi n-content); }
43 .gridFitContentAuto { grid-template: 20px / fit-content(100px) 5px minmax(0px, a uto); } 43 .gridFitContentAuto { grid-template: 20px / fit-content(100px) 5px minmax(0px, a uto); }
44 44
45 </style> 45 </style>
46 46
47 <div class="float"> 47 <div class="float">
48 48
49 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
50 <!--
51 <div class="grid gridMinContent"> 49 <div class="grid gridMinContent">
52 <div class="item" style="min-width: 15px;">XXXX XXXX</div> 50 <div class="item" style="min-width: 15px;">XXXX XXXX</div>
53 <div class="abs col1"></div> 51 <div class="abs col1"></div>
54 <div class="abs col2"></div> 52 <div class="abs col2"></div>
55 </div> 53 </div>
56 -->
57 54
58 <div class="grid gridMinContent"> 55 <div class="grid gridMinContent">
59 <div class="item" style="min-width: 55px;">XXXX XXXX</div> 56 <div class="item" style="min-width: 55px;">XXXX XXXX</div>
60 <div class="abs col1"></div> 57 <div class="abs col1"></div>
61 <div class="abs col2"></div> 58 <div class="abs col2"></div>
62 </div> 59 </div>
63 60
64 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
65 <!--
66 <div class="grid gridMinContent"> 61 <div class="grid gridMinContent">
67 <div class="item min-width-max-content">XXXX XXXX</div> 62 <div class="item min-width-max-content">XXXX XXXX</div>
68 <div class="abs col1"></div> 63 <div class="abs col1"></div>
69 <div class="abs col2"></div> 64 <div class="abs col2"></div>
70 </div> 65 </div>
71 -->
72 66
73 <div class="grid gridMaxContent"> 67 <div class="grid gridMaxContent">
74 <div class="item" style="min-width: 15px;">XXXX XXXX</div> 68 <div class="item" style="min-width: 15px;">XXXX XXXX</div>
75 <div class="abs col1"></div> 69 <div class="abs col1"></div>
76 <div class="abs col2"></div> 70 <div class="abs col2"></div>
77 </div> 71 </div>
78 72
79 <div class="grid gridMaxContent"> 73 <div class="grid gridMaxContent">
80 <div class="item" style="min-width: 55px;">XXXX XXXX</div> 74 <div class="item" style="min-width: 55px;">XXXX XXXX</div>
81 <div class="abs col1"></div> 75 <div class="abs col1"></div>
82 <div class="abs col2"></div> 76 <div class="abs col2"></div>
83 </div> 77 </div>
84 78
85 <div class="grid gridMaxContent"> 79 <div class="grid gridMaxContent">
86 <div class="item min-width-max-content">XXXX XXXX</div> 80 <div class="item min-width-max-content">XXXX XXXX</div>
87 <div class="abs col1"></div> 81 <div class="abs col1"></div>
88 <div class="abs col2"></div> 82 <div class="abs col2"></div>
89 </div> 83 </div>
90 84
91 </div> 85 </div>
92 86
93 <div class="float"> 87 <div class="float">
94 88
95 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
96 <!--
97 <div class="grid gridMinMaxContent"> 89 <div class="grid gridMinMaxContent">
98 <div class="item" style="min-width: 15px;">XXXX XXXX</div> 90 <div class="item" style="min-width: 15px;">XXXX XXXX</div>
99 <div class="abs col1"></div> 91 <div class="abs col1"></div>
100 <div class="abs col2"></div> 92 <div class="abs col2"></div>
101 <div class="abs col3"></div> 93 <div class="abs col3"></div>
102 </div> 94 </div>
103 -->
104 95
105 <div class="grid gridMinMaxContent"> 96 <div class="grid gridMinMaxContent">
106 <div class="item" style="min-width: 55px;">XXXX XXXX</div> 97 <div class="item" style="min-width: 55px;">XXXX XXXX</div>
107 <div class="abs col1"></div> 98 <div class="abs col1"></div>
108 <div class="abs col2"></div> 99 <div class="abs col2"></div>
109 <div class="abs col3"></div> 100 <div class="abs col3"></div>
110 </div> 101 </div>
111 102
112 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
113 <!--
114 <div class="grid gridMinMaxContent"> 103 <div class="grid gridMinMaxContent">
115 <div class="item min-width-max-content">XXXX XXXX</div> 104 <div class="item min-width-max-content">XXXX XXXX</div>
116 <div class="abs col1"></div> 105 <div class="abs col1"></div>
117 <div class="abs col2"></div> 106 <div class="abs col2"></div>
118 <div class="abs col3"></div> 107 <div class="abs col3"></div>
119 </div> 108 </div>
120 109
121 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
122 <!--
123 <div class="grid gridAutoMinContent"> 110 <div class="grid gridAutoMinContent">
124 <div class="item" style="min-width: 15px;">XXXX XXXX</div> 111 <div class="item" style="min-width: 15px;">XXXX XXXX</div>
125 <div class="abs col1"></div> 112 <div class="abs col1"></div>
126 <div class="abs col2"></div> 113 <div class="abs col2"></div>
127 <div class="abs col3"></div> 114 <div class="abs col3"></div>
128 </div> 115 </div>
129 -->
130 116
131 <div class="grid gridAutoMinContent"> 117 <div class="grid gridAutoMinContent">
132 <div class="item" style="min-width: 55px;">XXXX XXXX</div> 118 <div class="item" style="min-width: 55px;">XXXX XXXX</div>
133 <div class="abs col1"></div> 119 <div class="abs col1"></div>
134 <div class="abs col2"></div> 120 <div class="abs col2"></div>
135 <div class="abs col3"></div> 121 <div class="abs col3"></div>
136 </div> 122 </div>
137 123
138 <!-- Fails due to https://bugs.chromium.org/p/chromium/issues/detail?id=654737 - ->
139 <!--
140 <div class="grid gridAutoMinContent" style="justify-items: start"> 124 <div class="grid gridAutoMinContent" style="justify-items: start">
141 <div class="item min-width-max-content">XXXX XXXX</div> 125 <div class="item min-width-max-content">XXXX XXXX</div>
142 <div class="abs col1"></div> 126 <div class="abs col1"></div>
143 <div class="abs col2"></div> 127 <div class="abs col2"></div>
144 <div class="abs col3"></div> 128 <div class="abs col3"></div>
145 </div> 129 </div>
146 -->
147 130
148 </div> 131 </div>
149 132
150 <div class="float"> 133 <div class="float">
151 134
152 <div class="grid gridFitContentAuto"> 135 <div class="grid gridFitContentAuto">
153 <div class="item" style="min-width: 15px;">XXXX XXXX</div> 136 <div class="item" style="min-width: 15px;">XXXX XXXX</div>
154 <div class="abs col1"></div> 137 <div class="abs col1"></div>
155 <div class="abs col2"></div> 138 <div class="abs col2"></div>
156 <div class="abs col3"></div> 139 <div class="abs col3"></div>
157 </div> 140 </div>
158 141
159 <div class="grid gridFitContentAuto"> 142 <div class="grid gridFitContentAuto">
160 <div class="item" style="min-width: 55px;">XXXX XXXX</div> 143 <div class="item" style="min-width: 55px;">XXXX XXXX</div>
161 <div class="abs col1"></div> 144 <div class="abs col1"></div>
162 <div class="abs col2"></div> 145 <div class="abs col2"></div>
163 <div class="abs col3"></div> 146 <div class="abs col3"></div>
164 </div> 147 </div>
165 148
166 <div class="grid gridFitContentAuto"> 149 <div class="grid gridFitContentAuto">
167 <div class="item min-width-max-content">XXXX XXXX</div> 150 <div class="item min-width-max-content">XXXX XXXX</div>
168 <div class="abs col1"></div> 151 <div class="abs col1"></div>
169 <div class="abs col2"></div> 152 <div class="abs col2"></div>
170 <div class="abs col3"></div> 153 <div class="abs col3"></div>
171 </div> 154 </div>
172 155
173 </div> 156 </div>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698