Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Issue 2411673003: [css-grid] Fix intrinsic maximums resolution with fit-content and auto (Closed)

Created:
4 years, 2 months ago by svillar
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix intrinsic maximums resolution with fit-content and auto The step 2.5 in section 12.5 https://drafts.csswg.org/css-grid/#algo-content of the specs, details how to sizes tracks with intrinsic max track sizing functions. Not so long ago there were only two max track sizing functions min-content and max-content (auto was always resolved to max-content). However there were some recent changes that force us to consider 2 new values: auto (which is not internally translated to max-content although it still works the same) and specially the newly added fit-content. Some of the new tests are commented because they fail due to https://crbug.com/654737 which is about to be fixed. BUG=654739 Committed: https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d Cr-Commit-Position: refs/heads/master@{#424475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums.html View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html View 1 chunk +168 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridTrackSize.h View 3 chunks +16 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
svillar
Adding reviewers
4 years, 2 months ago (2016-10-11 13:37:49 UTC) #2
eae
LGTM
4 years, 2 months ago (2016-10-11 15:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411673003/1
4 years, 2 months ago (2016-10-11 15:44:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:42:10 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:43:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62dc3ff33032432888e0f08a2915df0e88b7c19d
Cr-Commit-Position: refs/heads/master@{#424475}

Powered by Google App Engine
This is Rietveld 408576698