Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2407173002: [builtins] Move StringStartsWith to a C++ builtin. (Closed)

Created:
4 years, 2 months ago by petermarshall
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move StringStartsWith to a C++ builtin. BUG=v8:5364 Committed: https://crrev.com/08217e45a79d81a4e302a8e042309de752dab7b3 Cr-Commit-Position: refs/heads/master@{#40165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -27 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -27 lines 0 comments Download
M test/mjsunit/es6/string-startswith.js View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
petermarshall
Very similar to StringEndsWith, PTAL
4 years, 2 months ago (2016-10-11 10:30:33 UTC) #6
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-10-11 10:37:11 UTC) #7
Franzi
On 2016/10/11 at 10:37:11, bmeurer wrote: > LGTM. LGTM
4 years, 2 months ago (2016-10-11 11:04:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407173002/1
4 years, 2 months ago (2016-10-11 11:33:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 11:36:05 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:36:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08217e45a79d81a4e302a8e042309de752dab7b3
Cr-Commit-Position: refs/heads/master@{#40165}

Powered by Google App Engine
This is Rietveld 408576698