Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2406873002: [builtins] Move StringEndsWith to a C++ builtin. (Closed)

Created:
4 years, 2 months ago by petermarshall
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move StringEndsWith to a C++ builtin. BUG=v8:5364 Committed: https://crrev.com/5af6ec76b29787415719de42e1f33d99b233142d Cr-Commit-Position: refs/heads/master@{#40164}

Patch Set 1 #

Patch Set 2 : Use Object::IsRegExp and add a test #

Patch Set 3 : Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into ends_with #

Patch Set 4 : Remove JS implementation of endsWith #

Patch Set 5 : Use a FlatStringReader instead" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -28 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
M src/js/string.js View 1 2 3 2 chunks +0 lines, -28 lines 0 comments Download
M test/mjsunit/es6/string-endswith.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (14 generated)
petermarshall
PTAL
4 years, 2 months ago (2016-10-11 07:15:26 UTC) #6
Franzi
On 2016/10/11 at 07:15:26, petermarshall wrote: > PTAL LGTM
4 years, 2 months ago (2016-10-11 09:28:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406873002/70001
4 years, 2 months ago (2016-10-11 11:15:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26123)
4 years, 2 months ago (2016-10-11 11:19:19 UTC) #15
petermarshall
Oops, Need bmeurer@ to review for owner
4 years, 2 months ago (2016-10-11 11:23:20 UTC) #16
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-10-11 11:24:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406873002/70001
4 years, 2 months ago (2016-10-11 11:24:58 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 2 months ago (2016-10-11 11:28:02 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:28:20 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5af6ec76b29787415719de42e1f33d99b233142d
Cr-Commit-Position: refs/heads/master@{#40164}

Powered by Google App Engine
This is Rietveld 408576698