Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: src/js/string.js

Issue 2407173002: [builtins] Move StringStartsWith to a C++ builtin. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | test/mjsunit/es6/string-startswith.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/string.js
diff --git a/src/js/string.js b/src/js/string.js
index 5d84858d84b38e50965628259b3d68e4c1e58b6b..f1a2c6326154053ed5b422406660247ee528df92 100644
--- a/src/js/string.js
+++ b/src/js/string.js
@@ -380,32 +380,6 @@ function StringRepeat(count) {
}
-// ES6 draft 04-05-14, section 21.1.3.18
-function StringStartsWith(searchString, position) { // length == 1
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.startsWith");
-
- var s = TO_STRING(this);
-
- if (IsRegExp(searchString)) {
- throw %make_type_error(kFirstArgumentNotRegExp, "String.prototype.startsWith");
- }
-
- var ss = TO_STRING(searchString);
- var pos = TO_INTEGER(position);
-
- var s_len = s.length;
- var start = MinSimple(MaxSimple(pos, 0), s_len);
- var ss_len = ss.length;
- if (ss_len + start > s_len) {
- return false;
- }
-
- return %_SubString(s, start, start + ss_len) === ss;
-}
-
-%FunctionSetLength(StringStartsWith, 1);
-
-
// ES6 Draft 05-22-2014, section 21.1.3.3
function StringCodePointAt(pos) {
CHECK_OBJECT_COERCIBLE(this, "String.prototype.codePointAt");
@@ -469,7 +443,6 @@ utils.InstallFunctions(GlobalString.prototype, DONT_ENUM, [
"search", StringSearch,
"slice", StringSlice,
"split", StringSplitJS,
- "startsWith", StringStartsWith,
"toLowerCase", StringToLowerCaseJS,
"toLocaleLowerCase", StringToLocaleLowerCase,
"toUpperCase", StringToUpperCaseJS,
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | test/mjsunit/es6/string-startswith.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698