Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

BUG=653459

[Lei Zhang, 2016-10-11 02:09:56]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 02:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-11 02:14:26]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:22:32]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-11 14:13:27]

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:165:
std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;
What does this need to be destroyed after, everything? Can you add a comment?

[Tom Sepez, 2016-10-11 16:28:01]

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:172: std::unique_ptr<CFX_SystemHandler>
m_pSysHandler;
Should this be the very last thing to go?

[Lei Zhang, 2016-10-11 19:38:28]

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:165:
std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;
On 2016/10/11 14:13:26, dsinclair wrote:
> What does this need to be destroyed after, everything? Can you add a comment?

I did this quickly last night. I think it needs to be destroyed after
|m_pAnnotHandlerMgr| ? Need to double check.

https://codereview.chromium.org/2406893003/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:172: std::unique_ptr<CFX_SystemHandler>
m_pSysHandler;
On 2016/10/11 16:28:01, Tom Sepez wrote:
> Should this be the very last thing to go?

Not sure. I didn't hit any known problems with this CL, but this may be
incorrect and I haven't thought about it too much.

[Tom Sepez, 2016-10-11 20:36:17]

lgtm

[Lei Zhang, 2016-10-11 21:24:10]

I'm going to close this because dsinclair wrote a similar patch.

[Lei Zhang, 2016-10-11 21:24:26]

Description was changed from

==========
Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

BUG=653459
==========

to

==========
Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

BUG=653459
==========