Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

fpdfsdk/cpdfsdk_formfillenvironment.h

Index: fpdfsdk/cpdfsdk_formfillenvironment.h
diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.h b/fpdfsdk/cpdfsdk_formfillenvironment.h
index e92537eee128cb4ae1bf4a200b701648f0e3f2a6..50ae966571ef3dc525f285414755ed7c44c44574 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.h
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.h
@@ -162,13 +162,13 @@ class CPDFSDK_FormFillEnvironment final {
   CPDFSDK_ActionHandler* GetActionHander();       // Creates if not present.
 
  private:
+  std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;

[dsinclair, 2016/10/11 14:13:26]

What does this need to be destroyed after, everything? Can you add a comment?

[Lei Zhang, 2016/10/11 19:38:28]

I did this quickly last night. I think it needs to be destroyed after
|m_pAnnotHandlerMgr| ? Need to double check.

   std::unique_ptr<CPDFSDK_AnnotHandlerMgr> m_pAnnotHandlerMgr;
   std::unique_ptr<CPDFSDK_ActionHandler> m_pActionHandler;
   std::unique_ptr<IJS_Runtime> m_pJSRuntime;
   FPDF_FORMFILLINFO* const m_pInfo;
   std::unique_ptr<CPDFSDK_Document> m_pSDKDoc;
   UnderlyingDocumentType* const m_pUnderlyingDoc;
-  std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;
   std::unique_ptr<CFX_SystemHandler> m_pSysHandler;

[Tom Sepez, 2016/10/11 16:28:01]

Should this be the very last thing to go?

[Lei Zhang, 2016/10/11 19:38:28]

Not sure. I didn't hit any known problems with this CL, but this may be
incorrect and I haven't thought about it too much.

 };