Fix member destruction ordering in CPDFSDK_FormFillEnvironment.

fpdfsdk/cpdfsdk_formfillenvironment.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_CPDFSDK_FORMFILLENVIRONMENT_H_
 #define FPDFSDK_CPDFSDK_FORMFILLENVIRONMENT_H_
 
 #include <memory>
@@ skipping 144 matching lines @@
   CFX_SystemHandler* GetSysHandler() const { return m_pSysHandler.get(); }
   FPDF_FORMFILLINFO* GetFormFillInfo() const { return m_pInfo; }
 
   // Creates if not present.
   CFFL_InteractiveFormFiller* GetInteractiveFormFiller();
   CPDFSDK_AnnotHandlerMgr* GetAnnotHandlerMgr();  // Creates if not present.
   IJS_Runtime* GetJSRuntime();                    // Creates if not present.
   CPDFSDK_ActionHandler* GetActionHander();       // Creates if not present.
 
  private:
+  std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;

[dsinclair, 2016/10/11 14:13:26]

What does this need to be destroyed after, everything? Can you add a comment?

[Lei Zhang, 2016/10/11 19:38:28]

I did this quickly last night. I think it needs to be destroyed after
|m_pAnnotHandlerMgr| ? Need to double check.

   std::unique_ptr<CPDFSDK_AnnotHandlerMgr> m_pAnnotHandlerMgr;
   std::unique_ptr<CPDFSDK_ActionHandler> m_pActionHandler;
   std::unique_ptr<IJS_Runtime> m_pJSRuntime;
   FPDF_FORMFILLINFO* const m_pInfo;
   std::unique_ptr<CPDFSDK_Document> m_pSDKDoc;
   UnderlyingDocumentType* const m_pUnderlyingDoc;
-  std::unique_ptr<CFFL_InteractiveFormFiller> m_pFormFiller;
   std::unique_ptr<CFX_SystemHandler> m_pSysHandler;

[Tom Sepez, 2016/10/11 16:28:01]

Should this be the very last thing to go?

[Lei Zhang, 2016/10/11 19:38:28]

Not sure. I didn't hit any known problems with this CL, but this may be
incorrect and I haven't thought about it too much.

 };
 
 #endif  // FPDFSDK_CPDFSDK_FORMFILLENVIRONMENT_H_